dji-sdk / Mobile-UXSDK-iOS

DJI Mobile UXSDK is a suite of product agnostic UI objects that fast tracks the development of iOS applications using the DJI Mobile SDK.
Other
73 stars 43 forks source link

Incorrect license comments in VideoPreviewer/VideoFrameExtractor.h and .m ? #28

Open dokazaki opened 6 years ago

dokazaki commented 6 years ago

The LICENSE.txt file states that Sample code is offered under MIT License, however the sample VideoPreviewer's VideoFrameExtractor.h and .m files contain comments that it is LGPL code from iFrameExtractor.

However, based on a diff of these files against the iFrameExtractor files it appears VideoFrameExtractor is completely different from iFrameExtractor, so unless iFrameExtractor is being linked in via .a files, which I don't see, the comments in your source code may be incorrect.

Please delete the incorrect comments or update your license file.

This is important for anyone wanting to use this sample code in a published app as we need to correctly attribute any open source that we use in our own licenses.