search

djiamnot / gdosc

OSC module for Godot game engine - it is now discontinued in favor of https://gitlab.com/frankiezafe/gdosc
Other
16 stars 1 forks source link

Deprecated can_build signature in config.py #13

Closed SpotlightKid closed 6 years ago

SpotlightKid commented 6 years ago

I get the following warning when compiling for latest Godot from git (3.1.x):

Warning: module 'gdosc' uses a deprecated can_build signature in its config.py file, it should be can_build(env, platform).

djiamnot commented 6 years ago

Thanks, updated in develop branch

jmpetroske commented 5 years ago

This breaks building for versions before that for godot, but its easy to change it back to can_build(env, platform). Perhaps there should be some discussion about how to keep different versions of godot modules for different godot versions?

djiamnot commented 5 years ago

With the plans to port to GDNative (which has already started https://gitlab.com/frankiezafe/gdnative_osc), I don't think I will be keeping the module afloat. Godot >3 seems to be the way of the future ;) But I'm interested to know of any arguments in favour of using GD 2.x these days.

jmpetroske commented 5 years ago

Yeah I agree. It just didn't build for me on 3.0.6 (the latest stable) without changing it. But yeah sounds like its not work any thought