Checkbox Label font-size And switch component

djibe / material

Material Design 2 for Bootstrap 4 (active fork of Daemonite Material)

https://djibe.github.io/material/

MIT License

68 stars 11 forks source link

Checkbox Label font-size And switch component #17

Open MROALI opened 4 years ago

MROALI commented 4 years ago

Hello, I think there is some amelioration that we can do to the checkbox :

the custom-control-label must have a font-size: 1rem. It looks too small in 0.875rem.
The Label must be aligned to the bottom of the checkbox.
The space between the checkbox and the label must be reduced.

1 rem font-size for the label give this :

Another thing that can be ameliorated is the color of the switch when validating the form. I think turn it all to green, which make us loose the visual info if the switch is on or off. Same thing if switch is disabled the visual color info is not shown. Do you have any idea what can we do ?

FYI : In the https://material.io/components/selection-controls if we put the switch to disable it conserves it's color. Because the information of activation is visible only by color..

https://material-components.github.io/material-components-web-components/demos/switch/

djibe commented 4 years ago

Hi, I'll investigate this

MROALI commented 4 years ago

Any news about the validation color issues for the switch component and disabled color also ?

djibe commented 4 years ago

Hi, considering https://material.io/components/selection-controls, Radio label is 14px. And it is inline-flex with align-items: center

MROALI commented 4 years ago

Any news about the switch validation color fix and also disabled switch.. https://material-components.github.io/material-components-web-components/demos/switch/

djibe commented 4 years ago

Hi, The disabled switch is here: https://djibe.github.io/material/docs/4.5/components/forms/#switches And I didn't understand what was wrong with it.

MROALI commented 3 years ago

Hi, The disabled switch is here: https://djibe.github.io/material/docs/4.5/components/forms/#switches And I didn't understand what was wrong with it. Scenario : Turn the switch on then disable it. ==> Switch must keep it's color and not transformed to gray Scénario 2 : If you validate a form which having a switch => even if the switch is off it's turning all its color to green. ==> The problem is we loose the info that the switch was off..

As I said before the information about the switch on or off is by its color so even when validating we must not put it all to green, we must keep the information (switch on / off)

djibe commented 3 years ago

Thanks for feedback. I'm on it. But Bootstrap simple markup makes it harder to set opacity on switch.