search

djibe / material

Material Design 2 for Bootstrap 4 (active fork of Daemonite Material)
https://djibe.github.io/material/
MIT License
68 stars 11 forks source link

Bootstrap 5? #20

Open cheesycod opened 3 years ago

cheesycod commented 3 years ago

@djibe when do u plan to add bootstrap 5

djibe commented 3 years ago

Hi,

I'll have to dig into it. But it's a huge work alone. 4.6 coming soon.

Duplore commented 3 years ago

@djibe i could help a tiny bit with css 😄

djibe commented 3 years ago

Hi, I have a baby incoming and cannot invest more on it now. If I create the base files in a branch, can you work on it ?

Duplore commented 3 years ago

@djibe if you got a discord we can keep in contact and I would love to contribute my time

djibe commented 3 years ago

Hi @Kloptoe , thanks for your participation.

What are your skills ? What will be difficult is to bring the JavaScript plugins to ES6.

Duplore commented 3 years ago

i know css, html, Scss

Duplore commented 3 years ago

*still learning SCSS

Duplore commented 3 years ago

@djibe

djibe commented 3 years ago

Hi. Thanks. I'll try setting the base for BS5. However it is a totally new project architecture and technologies (Hugo, variables and latest CSS specs so it will require a lot of work)

Duplore commented 3 years ago

alright, do you got a discord if so that'll be great to keep contact in case I got anything to ask

djibe commented 3 years ago

Well, Discord is not my Generation :D Skype ? :D

Duplore commented 3 years ago

i'll download it ye

Duplore commented 3 years ago

got it now to figure out how to add you lmao

Duplore commented 3 years ago

@djibe

djibe commented 3 years ago

add live:djibe89

Duplore commented 3 years ago

added @djibe

stsrki commented 3 years ago

The Bootstrap 5 is going to be needed soon for my project and I would also like to help with this if needed.

@djibe How do you plan to proceed with Bootstrap 5? Considering it is quite different from Bootstrap 4 I think creating a new repository would be the best option.

djibe commented 3 years ago

Hi everyone. Thanks for your messages. I was hesitating to create a new repo. I will.

How should I name the project:

stsrki commented 3 years ago

Out of all, "Bootstrap 5 Material" is self-descriptive.

Other choices

djibe commented 3 years ago

Repo created: https://github.com/djibe/bootstrap-5-material

I'll have to dig in and set the base for your contribution

stsrki commented 3 years ago

The initial PR with Bootstrap is created.

Can you make me a contributor on a repo? Or do you prefer I work on my own fork?

stsrki commented 3 years ago

@djibe Thanks for adding me as a contributor.

Regarding the previous PR, I might have made a mistake. Instead of adding a full Boostrap source, it might be better to use their own startup template and then only add Bootstrap as a dependency. See their guide https://getbootstrap.com/docs/5.0/customize/overview/

startup template at https://github.com/twbs/bootstrap-npm-starter

What do you think it the best approach? Since you have more experience with setting the project maybe you can make it faster. If not I can do it, although it would take more time :)

djibe commented 3 years ago

Hi.

Thanks for the PR I did the same last night :D

Since we heavily modify the code I don't see how we can use it as a dependency. What do you think ?

stsrki commented 3 years ago

Well, having full source code with all documentation page have its benefits. But we will need to keep track of any changes in the main bootstrap repo. For now it can stay like this and later we can refactor if needed.

djibe commented 3 years ago

Yipeee: https://blog.getbootstrap.com/2021/05/05/bootstrap-5/

stsrki commented 3 years ago

Just saw it earlier. I guess it is time to slowly start migrating :)

ayoubkhan558-zz commented 3 years ago

When you are planning to update to Bootstrap 5?

djibe commented 3 years ago

Hi, I won't be able to do this with 2 kids. I could help, but can't be alone.