Feature Requests

[r0hin]

Hi, had some potential feature requests:

• Custom select something like this
• list in the readme or someplace listing the changes from the original fork.
• Ripple effect
• In the text fields, add a ripple to the underline like this
• Closing modal animation like in the original repo

There are just some things I think would be cool if added here. Just kinda to make it more like google's version.

Thanks!

[djibe]

Hi, thx for your requests. I share your wishes and will try to do my best (even though I am no developer at all).

I'll start with ripple effect.

For the closing animation of Dialogs, I don't think it is a good idea because Material components don't have this effect ;

• https://material-components.github.io/material-components-web-catalog/#/component/dialog
• https://material.io/components/dialogs#behavior

[r0hin]

Hi, thanks for trying!

I'm also not a developer, but I suppose I have some experience and could contribute some things. As for the modal, I was thinking like a fade effect like the examples you sent.

I would recommend implementing something like Fians Waves Effect as it looks pretty clean and I've used it before.

[djibe]

I'm on it at this exact moment :D

[r0hin]

Awesome thanks so much. I guess while I'm here I should mention some things like tabs which aren't present in the forked version but are there in the original repo.

Edit: Found out I was being dumb, tabs exist!

[djibe]

These tabs ?

https://djibe.github.io/material/docs/4.4/material/tabs/

[r0hin]

omg yes... the search feature, i thought it was just no results for tabs !!

[djibe]

Search field is disabled. Dependant on algolia. I'll have to fix it too.

Look at every Material component and tell me what you think.

[r0hin]

I've pretty inexperienced I would say but here's my feedback:

• Buttons, cards, chips, progress, shadows, lists, and data tables are remarkably similar to google's specifications, missing waves obviously
• Dialogs missing a fade imo
• Menu & Dropdown animations could be tweaked kind of like material components version
• The drawers could also be tweaked ie: drawer header should be same color & subtitles smaller.
• Snackbars are good, but I would never use them when I can just call Snackbar.show({text: "Text here"}) with SnackbarJS. Maybe add some functionality to call a snackbar without having the actual snackbar div element. Also, support for multiple snackbars at once.
• Tabs are great I love the fade
• Forms: I think a lot should be changed here such as the ripple on the line like i mentioned before, a custom select menu

That's pretty much all the feedback I have a lot of it is just personal preference of what I think would look good. Pretty excited on working on this w/ u. gonna try contributing my 2 cents to the code sometime :)

[djibe]

Good news, I did line ripple and button ripple yesterday.

Now I have to integrate it nicely.

[djibe]

You can test line ripples here : https://djibe.github.io/material/docs/4.4/material/text-fields/

[djibe]

You can test button ripples here : https://codepen.io/djibe89/pen/oNjMjQx

[r0hin]

Ripples are great!! Nice to see this quick progress

[r0hin]

I imagine this will be applied to all the other parts of UIs: ie the dropdown menus, tabs, selects.., right?

[djibe]

Yep

[r0hin]

Hey, noticed a small bug in the demo on codepen. If you click directly on the icon in the button, the waves effect doesn't show.

[djibe]

Yep I noticed, I'm on it

[djibe]

Fixed by luncheon https://codepen.io/luncheon/pen/zYvLNvM

[r0hin]

looks great!

[r0hin]

I think I got git contributing figured out :D was wondering if you need any help with any components or if anything is unfinished?

[djibe]

Hey ! Git is good :D

I had troubles with switch component. It is the last one missing I think. I enhenced Buttons + icons yesterday (Fontawesome 4 + 5 + svg support)

[r0hin]

Alright, I have it cloned and everything, how do you usually do development?

[djibe]

I usually have an HTML page in a folder. And copy latest material.css and material.map.css in it.

Then I customize component using