search

djipco / hpgl

A Node.js library to communicate with HPGL-compatible plotters and printers.
MIT License
38 stars 4 forks source link

function call to isOpen now a property value check #4

Closed juliendorra closed 6 years ago

juliendorra commented 6 years ago

Fix #3 and makes the module work with the current version of node SerialPort.

djipco commented 6 years ago

Bonjour Julien. Thanks for the PR. However, I would prefer not to break backwards-compatibility. It would be best to first check if isOpen is available and, if not, fallback to using isOpen().

juliendorra commented 6 years ago

Added a check. Also indicated the dependency in package.json, that could help new users installing.

djipco commented 6 years ago

There seems to be a discrepancy between the serialport module and the browser-serialport module on this regard.

djipco commented 6 years ago

This has been fixed in the latest version. Closing.