search

djipco / webmidi

Tame the Web MIDI API. Send and receive MIDI messages with ease. Control instruments with user-friendly functions (playNote, sendPitchBend, etc.). React to MIDI input with simple event listeners (noteon, pitchbend, controlchange, etc.).
Apache License 2.0
1.52k stars 115 forks source link

Extend playNote to handle note[] #345

Closed tobyhede closed 1 year ago

tobyhede commented 1 year ago

Fix for https://github.com/djipco/webmidi/issues/344

djipco commented 1 year ago

Awesome! Thanks for the PR.

Would you feel comfortable writing a unit test for this scenario? The unit tests for OutputChannel are in this file: /test/OutputChannel.test.js

tobyhede commented 1 year ago

On it, should have checked for tests

tobyhede commented 1 year ago

Added a couple of new test cases @djipco

djipco commented 1 year ago

This looks great! The tests run fine on my side too. Thanks a lot for the PR. It has been included in realease 3.1.5. Cheers!