djirdehh / crypto_vue

💠 A Vue.js based real-time dashboard of the top 10 cryptocurrencies
https://www.cryptovue.com/
351 stars 53 forks source link

Trim bundle size (and/or remove unused assets) #3

Open housseindjirdeh opened 7 years ago

housseindjirdeh commented 7 years ago

So the service worker file generated is a nice chunky 5MB

image

  1. If there's room for improvement, will love to explore how we can cut our bundle sizes down to the users
  2. All the images stored in the static folder, are all needed or can we remove some that are unused?

💃 🕺

djirdehh commented 7 years ago

Yeah I noticed this as well. I've compressed all the image assets already. I've added more images of cryptocurrency logos to the static folder than the current best ten performing purely to allow a visual display of new cryptocurrencies that may enter the top ten.

Which leaves me to consider eventually hosting all of the assets on an external server as opposed to storing them locally - since I'll be adding even more assets.

housseindjirdeh commented 7 years ago

Agreed it might definitely make more sense to host them on a server (if there isn't hosting that does it already)