[homer] Update bjw-s dependency version

Saintetix commented 4 days ago

Describe the bug a clear and concise description of what the bug is.

Homer's chart use an older version of bjw-s helm-charts.

dependencies:
  - name: common
    repository: http://bjw-s.github.io/helm-charts/
    version: 0.2.0

Currently, the version is at 3.5.1. Maybe you can set the dependency version to the new one ?

What's your helm version?

v2.17.0

What's your kubectl version?

v1.28.15

Which chart?

homer

What's the chart version?

8.2.0

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

No response

Enter the changed values of values.yaml?

No response

Enter the command that you execute and failing/misfunctioning.

helmfile sync -l app=homer

Anything else we need to know?

No response

djjudas21 commented 3 days ago

I'll have a look at this. I tried to increase the version in the past and I ran into problems that would have required code changes in some of my charts, so I rolled it back. It's probably worth another look 🙂

Saintetix commented 3 days ago

Don't worry 🙂 Maybe you can just write in the doc the right inherit values file ?

djjudas21 commented 2 days ago

I had another look at this. When I upgraded the dep from 0.2.0 to 3.5.1 the chart doesn't even work any more, and needs refactoring. I also checked out the upgrade guide from bjw-s and doing this huge leap from from 0.x to 3.x has several breaking changes, and looks like it would also break existing installations of this chart.

https://bjw-s.github.io/helm-charts/docs/app-template/#from-1xx-to-20x

So, for now I will keep using the ancient version of bjw-s/common until I need a feature that only exists in the newer versions.

But I will take your suggestion and list the correct version of the values file :slightly_smiling_face:

djjudas21 / charts