djjudas21 / charts

Collection of Helm charts
15 stars 6 forks source link

[graphite-exporter] Allow setting graphite port and add metric mapping option #24

Closed MartinHell closed 1 year ago

MartinHell commented 1 year ago

Hi,

This PR adds the option to set the graphite listening port. This is needed in some cases (Truenas doesn't allow changing the port in a persistent way when exporting data).

I've also added the option for a configmap containing graphite metric mappings (https://github.com/prometheus/graphite_exporter#metric-mapping-and-configuration).

These changes should only be activated if someone requires them. The port change edits the run command for the container but since port 9109 is the default value in values.yaml this shouldn't be an issue.

Let me know if you want me to change anything! :)

djjudas21 commented 1 year ago

OK I've reviewed this and I'm happy with the changes. Thanks for your contribution!

djjudas21 commented 1 year ago

This was published in https://github.com/djjudas21/charts/releases/tag/graphite-exporter-0.1.5