Bump minimum stdlib version to be 4.25.0

djjudas21 / puppet-freeradius

Puppet module to install and configure FreeRADIUS

Apache License 2.0

8 stars 49 forks source link

Bump minimum stdlib version to be 4.25.0 #193

Closed sircubbi closed 1 year ago

sircubbi commented 1 year ago

bump version-requirement for stdlib to 4.25.0 (needed for Stdlib::IP::*)
further enforce serveraddress in sql to be an ip-address and no subnet
remove unnecessary Optional[] for already defined valued

sircubbi commented 1 year ago

Added suggestions from #192

BTW: looking at the code there are some more Optionals with predefined values, maybe those can be cleaned up too, but I guess those are better in a separate PR.

djjudas21 commented 1 year ago

@nward This looks ok to me by eye but I have no way of testing it. Are you able to review & merge? I think we're getting to a stage where we should do a new release, so I want to get as many PRs merged as possible