Open djjudas21 opened 1 year ago
Originally posted by @cruelsmith in https://github.com/djjudas21/puppet-freeradius/pull/199#pullrequestreview-1580518137
FYI: There are still some PDK warnings that has not been fixed by me. See forexample https://github.com/djjudas21/puppet-freeradius/actions/runs/5879050878/job/15942322938?pr=199#step:4:16
I would recommend to add --fail-on-warnings to .puppet-lint.rc so that the CI fails when also warnings exist. This can be also be added with
--fail-on-warnings
.puppet-lint.rc
Rakefile: linter_fail_on_warnings: true
into .sync.yaml to make it persistent on pdk updates.
.sync.yaml
Originally posted by @cruelsmith in https://github.com/djjudas21/puppet-freeradius/pull/199#pullrequestreview-1580518137
FYI: There are still some PDK warnings that has not been fixed by me. See forexample https://github.com/djjudas21/puppet-freeradius/actions/runs/5879050878/job/15942322938?pr=199#step:4:16
I would recommend to add
--fail-on-warningsto.puppet-lint.rcso that the CI fails when also warnings exist. This can be also be added withinto
.sync.yamlto make it persistent on pdk updates.