search

djjudas21 / puppet-winbind

Puppet module to add Linux machines to a Windows domain using Winbind
Apache License 2.0
2 stars 6 forks source link

support configurable smb.conf #1

Closed systeemkabouter closed 7 years ago

systeemkabouter commented 7 years ago

Currently the module uses the compile default configuration file smb.conf . The net command manpage states that the file used can be specified with the -s flag. This is an effective way to split the managing of fileshares and authentication.

-s|--configfile The file specified contains the configuration details required by the server. The information in this file includes server-specific information such as what printcap file to use, as well as descriptions of all the services that the server is to provide. See smb.conf for more information. The default configuration file name is determined at compile time.

I am willing to create the PR that implements that if you are open to my suggestion.

djjudas21 commented 7 years ago

I think this would be a useful feature. If you go ahead and implement the feature, I'll QA it in the New Year. Thanks!

systeemkabouter commented 7 years ago

https://github.com/djjudas21/puppet-winbind/pull/2

djjudas21 commented 7 years ago

I'll close this too, as #2 has been accepted