djk2 / django-admin-shell

Django/Python shell for django admin site.
MIT License
77 stars 11 forks source link

static and templates missing from the sdist #2

Closed jayvdb closed 4 years ago

jayvdb commented 4 years ago

When I install from the tarball on PyPI (https://files.pythonhosted.org/packages/b2/c1/fd63da46620e9f0853559f360666c4fe2c0613e0dde86fa38fdca863aab7/django-admin-shell-0.1.1.tar.gz), I get:

django.template.exceptions.TemplateDoesNotExist: django_admin_shell/shell.html

As you are using include_package_data=True, I think you can/should omit the trickier package_data={..}. However getting this right can depend heavily on the version of setuptools you are using. check-manifest is also helpful, but it is getting confused by the symlink in demo/ and trying to put a lot of extra duplicated stuff into the sdist as a result.

djk2 commented 4 years ago

Hi. Thank you so much for your message.

Your remarks are very helpful. I created this project a long time ago, so then I not had enough knowledge about python packages. Probably a lot is to correct.

Can you open new issue on my github? https://github.com/djk2/django-admin-shell

Will be great if you can prepare some pull request to solve it. Best regards.

W dniu 21.05.2020 o 00:38, John Vandenberg pisze:

When I install from the tarball on PyPI (https://files.pythonhosted.org/packages/b2/c1/fd63da46620e9f0853559f360666c4fe2c0613e0dde86fa38fdca863aab7/django-admin-shell-0.1.1.tar.gz), I get:

|django.template.exceptions.TemplateDoesNotExist: django_admin_shell/shell.html|

As you are using |include_package_data=True|, I think you can/should omit the trickier |package_data={..}|. However getting this right can depend heavily on the version of setuptools you are using. |check-manifest| is also helpful, but it is getting confused by the symlink in demo/ and trying to put a lot of extra duplicated stuff into the sdist as a result.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/djk2/django-admin-shell/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS3RGTAFZDUEXA3LTX5YMTRSRLXVANCNFSM4NGLUBRQ.

--

Grzegorz Tężycki tel : 505-703-890 www : https://github.com/djk2

djk2 commented 4 years ago

Hi. I solved problem with missing files in sdist package (zip / tar.gz). I added MANIFEST file to version 0.1.2. New release was created.

jayvdb commented 4 years ago

Verified. Thanks!