search

djk2 / django-tables2-column-shifter

Simple extension for django-tables2 can dynamically show or hide columns. Using JQuery, Bootstrap 3, Bootstrap 4, Bootstrap 5 and Django >=1.9
BSD 3-Clause "New" or "Revised" License
21 stars 8 forks source link

Bootstrap 4.1.3 #13

Closed Nilad closed 6 years ago

Nilad commented 6 years ago

Hi,

Nice to see that you up to date this tool. Here i discover that django-tables2-column-shifter is not working with Bootstrap 4.1.3.

djk2 commented 6 years ago

Thanks for info. I will try verify and fix problem.

djk2 commented 6 years ago

In Bootstrap 4.1.3 documentation https://getbootstrap.com/docs/4.1/getting-started/introduction/#js authors said that Popper.js is required. I tested with popper library and everything works fine. Probably you forgot about this require.

<script src="{% static "bootstrap4.1.3/js/popper.min.js" %}"></script>
<script src="{% static "bootstrap4.1.3/js/bootstrap.min.js" %}"></script>

I extended testproject and added example for B4.1.3, please see: https://github.com/djk2/django-tables2-column-shifter/tree/issue%2313/testproject. Example added in branch: issue#13

Nilad commented 6 years ago

Yes, i forgot this require.

Everything works great.

Thanks for your reply.