search

djk2 / django-tables2-column-shifter

Simple extension for django-tables2 can dynamically show or hide columns. Using JQuery, Bootstrap 3, Bootstrap 4, Bootstrap 5 and Django >=1.9
BSD 3-Clause "New" or "Revised" License
21 stars 8 forks source link

adding possibiliity to select hideable columns #25

Closed Najiva closed 1 year ago

Najiva commented 3 years ago

I will review the comments and update the updated commit later this month.

djk2 commented 3 years ago

Hi, thanks for your PR. No problem. anytime.

Najiva commented 3 years ago

I added test and also a css file since it was not there yet. Also updated the version and readme. Please check if its OK.

Najiva commented 3 years ago

Hi. I believe it is like that. Non-hidable columns are visible. But you cannot hide them (because they are disabled). Maybe what you mean is that also the state should be in that case reset to Visible.

djk2 commented 3 years ago

Hi Najiva, I still wait for your changes to PR. Can you replay for my remarks and push code forward? Your last reply not explain my all doubts. Please, review all my comments and apply some of them. Thanks for attention.

Najiva commented 3 years ago

Hi,I am sorry I dont have any free time anymore.Najiva

On Monday, July 19, 2021, 8:17 AM, K2 @.***> wrote:

Hi Najiva, I still wait for your changes to PR. Can you replay for my remarks and push code forward? Your last reply not explain my all doubts. Please, review all my comments and apply some of them. Thanks for attention.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

djk2 commented 3 years ago

Don't worry, I exactly know how is. I'm also always on the go and haven't any free time. Go back to me, when you will be have a moment. I will left your PR still open. To next time.