djkato / DRP_Creative

Show your friends what you're working on, be it in Adobe Suite, Autodesk Suite, Cinema 4D or many more! Currently supported: C4D, Adobe Suite, Davinci Resolve, Maya, 3Ds Max, Sony Vegas, Substance suite, Isotropix suite, FL, Ableton, Blender, Cavalry, Zbrush
22 stars 3 forks source link

Cinema 4D Detection Issue #11

Open sashinator opened 11 months ago

sashinator commented 11 months ago

DRP Creative Build: v1.0.3 Cinema 4D Build: 2023.0.1 (2023.CL38444.44159)

I was really excited to find this program, so was a bit bummed when I couldn't get it to actually work with the program I downloaded it for. I did all the basic troubleshooting I could think of: closing and reopening Discord and C4D, making sure there was no setting causing this to happen, restarting, etc. but still couldn't get it to work.

I haven't ever really done any coding, but for some reason thought maybe I could determine what this was coded in, install the appropriate programs, and try to fix it myself. So I did!

On Line 122, the "process_search_string" variable is "Cinema 4D R", whereas the process name of my Cinema4D version is "Cinema 4D 2023.0.1" with project info afterwards. Removing the R and running that version caused it to work with no issues: image

djkato commented 11 months ago

Aah I see. Yeah the "R" there was intentional as it was added to help not detect browser searches of "Cinema 4D how to..". I made this back when R was still common, so I will push a fix soon.

sashinator commented 11 months ago

Nice! I sent over a pull request but you explaining why the R was there makes a lot of sense. Thanks again for making this program so my friends can laugh at how long I've had C4D open, haha

AlehSId commented 10 months ago

Nice! I sent over a pull request but you explaining why the R was there makes a lot of sense. Thanks again for making this program so my friends can laugh at how long I've had C4D open, haha

can u send correct version?

djkato commented 10 months ago

@AlehSId @sashinator I saw the PR #12 , but didn't have time yet. I do not have access to windows(switched to linux) for the next month, so I cannot release a build. If you're willing to get your hands dirty, I could walk you through how to build it for yourself, but if not this'll have to wait for a month. Sorry.

AlehSId commented 10 months ago

@djkato Can you please tell me how I can fix it myself?

djkato commented 10 months ago

@AlehSId

  1. rustup
  2. download sashinators PR, extract to folder
  3. open CMD or any terminal, navigate your terminal to the folder where you put that PR
  4. type cargo build --release
  5. new folder will appear there, your .exe should be in ./target/release/(some name).exe
  6. run, profit.

You won't get update notif tho when I release it officially later, but if sashinator found the issue it should hopefully work.

sashinator commented 10 months ago

I can compile a build and add it to my PR today.

sashinator commented 10 months ago

@AlehSId I have attached a compiled build to the pull request.

Dragoy commented 10 months ago

There is a bug, the line with the project name display is now ignored in the config: "show_default_when_excluded = false "