djkoloski / rust_serialization_benchmark

Benchmarks for rust serialization frameworks
527 stars 48 forks source link

Add alkahest serializer #21

Closed zakarumych closed 2 years ago

zakarumych commented 2 years ago

This adds new alkahest serializer to the benchmark. Updated README.md with bench results.

djkoloski commented 2 years ago

Also, not a blocking request, but would it be possible to add a deserialize benchmark for alkahest? If I'm understanding correctly it should just be a few recursive functions. If you'd rather not, that's totally fine.

zakarumych commented 2 years ago

Also, not a blocking request, but would it be possible to add a deserialize benchmark for alkahest? If I'm understanding correctly it should just be a few recursive functions. If you'd rather not, that's totally fine.

Alkahest doesn't provide a data structure to deserialize data into. It can be implemented in the benchmark as reading data back into original data structure.

djkoloski commented 2 years ago

Okay, I'm fine leaving it as a footnote for now. Maybe it's a feature that could be added to alkahest eventually.

djkoloski commented 2 years ago

@zakarumych I'd like to get this PR merged with the following changes:

I can make these changes if you'd like. 🙂

djkoloski commented 2 years ago

@zakarumych I'll go ahead and get this integrated with the changes mentioned above. 🙂

zakarumych commented 2 years ago

Thanks! Then I'll open new PR when I'd finish with deserialization. I kinda works in master, but I'd like to be sure it feels alright and for that I'm going to start using alkahest ^_^

djkoloski commented 2 years ago

Awesome! Good luck as well!

djkoloski commented 2 years ago

Just as a heads-up, I'm going to rerun the benchmarks but I want to clarify upfront that this is not because I don't trust your numbers. While doing the merge, I realized that there wasn't a raw benchmark log added to the benchmark_results directory. Sorry about this, it's my fault as I completely forgot to ask you to provide one. I like to keep these logs so that we have historical data about how the benchmarked libraries have improved or regressed over time.

djkoloski commented 2 years ago

Benchmarks are updated! 🎉

zakarumych commented 2 years ago

Fantastic. Thank you!