djkoloski / rust_serialization_benchmark

Benchmarks for rust serialization frameworks
514 stars 48 forks source link

Update savefile to version 0.16 #49

Closed avl closed 9 months ago

avl commented 9 months ago

I've been running the benchmark a lot, and investigated why savefile didn't perform as well as some of the other libraries.

This proved very helpful, and I've realized that carrying a '&mut dyn Write' instead of making the serializer generic was very expensive. So, I've redesigned this aspect of Savefile, and done some more optimizations, and released version 0.16.

It is much faster!

It would be nice to have this new version in the benchmark!

djkoloski commented 9 months ago

Looks good, thanks for the PR!

avl commented 9 months ago

I notice that the front-page has not yet updated. Is there a need to trigger some github action or something like that? Or did the benchmark run fail?

djkoloski commented 9 months ago

Thanks for pointing that out, I had the trigger for benchmarking set to branches: main, forgetting that this repo is relatively old and has a master branch instead. THat's been fixed and a new bench is underway.