djkoloski / rust_serialization_benchmark

Benchmarks for rust serialization frameworks
514 stars 48 forks source link

Pin deps #73

Closed mumbleskates closed 4 weeks ago

mumbleskates commented 4 weeks ago

(This PR is dependent upon #72. Only the last commit in this PR does the thing.)

This does not change the version of any of the dependencies as they would be resolved in a fresh repo now. it does avoid newly published versions of upstream crates breaking things, like changing the generated files in prost-build or updating performance characteristics without changing the api.

Just as importantly, this actually causes the contents of Cargo.toml to accurately reflect the versions of the dependencies that are resolved, which shows some some pretty significant drift in the version numbers in a lot of these cases.

Probably the best way to check for outdated dependencies here is cargo oudated --depth 1, with "cargo-outdated" installed. Performing that task before updating the benchmarks seems like a reasonable addition to the workflow and can make tracking the provenance of these performance numbers a lot easier.

Of course the goal here is to make maintaining and updating the repo and tracking what's going on with it easier, and if you as the maintainer don't think it serves that purpose then :woman_shrugging: :put_litter_in_its_place: :smile:. I just reckon this seems like a probable improvement.