search

djkoloski / rust_serialization_benchmark

Benchmarks for rust serialization frameworks
527 stars 48 forks source link

Fix wiring size #81

Closed caibear closed 1 week ago

caibear commented 1 week ago

The buffer wasn't being cleared before serializing again to measure size. As a result the size benchmarks were twice as high as they should have been.

djkoloski commented 1 week ago

Thanks for noticing, something related came up on the original PR but this one got overlooked.

louaykamel commented 1 week ago

My apologies for the oversight. I became aware of the issue some time ago and have been mindful not to inundate the repository. A fix was scheduled for inclusion in my forthcoming PR, coinciding with the next release. Additionally, it’s worth noting that the benchmark results on my Intel machine have shown a notable variance, which is quite intriguing.