search

djkormo / adcs-issuer

BSD 3-Clause "New" or "Revised" License
22 stars 11 forks source link

Default simulator helm chart values conflict #104

Open EliSauder opened 2 months ago

EliSauder commented 2 months ago

The default values for simulator.enabled and simulator.exampleCertificate.enabled don't match. This can result in a state where you have disabled the simulator but still create the certificate.

https://github.com/djkormo/adcs-issuer/blob/96f3605d8a310dc6324c78539f809ba866ed3f3e/charts/adcs-issuer/values.yaml#L142

https://github.com/djkormo/adcs-issuer/blob/96f3605d8a310dc6324c78539f809ba866ed3f3e/charts/adcs-issuer/values.yaml#L263

Recommendation: Add additional configuration to the example certificate to check both variables https://github.com/djkormo/adcs-issuer/blob/96f3605d8a310dc6324c78539f809ba866ed3f3e/charts/adcs-issuer/templates/simulator-example-certificate.yaml#L1 Change to:

{{- if and .Values.simulator.enabled .Values.simulator.exampleCertificate.enabled }}
djkormo commented 1 month ago

Thats correct. It will be added on the next versions.