djkormo / adcs-issuer

BSD 3-Clause "New" or "Revised" License
22 stars 11 forks source link

"Couldn't get issuer", due to "error loading ADCS CA bundle" #84

Closed KrystianMarek closed 8 months ago

KrystianMarek commented 8 months ago

I think I have it as described in the readme, but for some reason I cant get the issuer. Please find the logs attached below. Aren't you missing sort of decodedCABundle, err := base64.StdEncoding.DecodeString(certs) after https://github.com/djkormo/adcs-issuer/blob/master/issuers/issuer_factory.go#L118 ?

apiVersion: adcs.certmanager.csf.nokia.com/v1
kind: ClusterAdcsIssuer
metadata:
  name: pki.some_company.xyz
spec:
  caBundle: [ 'base64 -i bundle.p7b']
  # (...) remainder omitted 

ts=2024-03-12T12:13:17.357193955Z level=error msg="Couldn't get issuer" controller=adcsrequest controllerGroup=adcs.certmanager.csf.nokia.com controllerKind=AdcsRequest AdcsRequest="{tls.dev2.meta.some_company.xyz-v6g6h helm-chart-update}" namespace=helm-chart-update name=tls.dev2.meta.some_company.xyz-v6g6h reconcileID=a113859f-128f-469b-8065-e1aeaab998a3 adcsrequest="{tls.dev2.meta.some_company.xyz-v6g6h helm-chart-update}" issuer="{pki.some_company.xyz ClusterAdcsIssuer adcs.certmanager.csf.nokia.com}" error="error loading ADCS CA bundle" stacktrace="github.com/nokia/adcs-issuer/controllers.(*AdcsRequestReconciler).Reconcile\n\t/workspace/controllers/adcsrequest_controller.go:75\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"
ts=2024-03-12T12:13:17.35727353Z level=error msg="Reconciler error" controller=adcsrequest controllerGroup=adcs.certmanager.csf.nokia.com controllerKind=AdcsRequest AdcsRequest="{tls.dev2.meta.some_company.xyz-v6g6h helm-chart-update}" namespace=helm-chart-update name=tls.dev2.meta.some_company.xyz-v6g6h reconcileID=a113859f-128f-469b-8065-e1aeaab998a3 error="error loading ADCS CA bundle" stacktrace="sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"
ts=2024-03-12T12:14:39.277655181Z level=info msg="Processing request" controller=adcsrequest controllerGroup=adcs.certmanager.csf.nokia.com controllerKind=AdcsRequest AdcsRequest="{tls.dev2.meta.some_company.xyz-v6g6h helm-chart-update}" namespace=helm-chart-update name=tls.dev2.meta.some_company.xyz-v6g6h reconcileID=acbb4f24-6cda-4965-ab66-c29894f01275 adcsrequest="{tls.dev2.meta.some_company.xyz-v6g6h helm-chart-update}"```
KrystianMarek commented 8 months ago

I tried to push a bundle instead of a single certificate. Works for a single certificate.