djkormo / adcs-issuer

BSD 3-Clause "New" or "Revised" License
22 stars 11 forks source link

Bypassing TLS check during cert issuing by ADCS Certserv #85

Closed ghost closed 8 months ago

ghost commented 8 months ago

Hello, Is there a way to bypass the TLS check when calling the ADCS Certserv. In my company, the ADCS server certificate is expired, and I'm not able to renew it by myself. I've encountered the following error : ts=2024-03-13T17:28:38.789851847Z level=error logger=RequestCertificate msg="ADCS Certserv error" template=WebServer error="Post \"https://<adcs_server>/certsrv/certfnsh.asp\": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2024-03-13T17:28:38Z is after 2019-06-12T14:47:53Z" stacktrace="github.com/nokia/adcs-issuer/adcs.(*NtlmCertsrv).RequestCertificate\n\t/workspace/adcs/ntlm_certsrv.go:262\ngithub.com/nokia/adcs-issuer/issuers.(*Issuer).Issue\n\t/workspace/issuers/issuer.go:57\ngithub.com/nokia/adcs-issuer/controllers.(*AdcsRequestReconciler).Reconcile\n\t/workspace/controllers/adcsrequest_controller.go:83\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"

Can we ignore this kind of errors ? Thanks

djkormo commented 8 months ago

You say that you have adcs with expired certificate about 5 years ago ?

current time 2024-03-13T17:28:38Z is after 2019-06-12T14:47:53Z"