djleong01 / pe

0 stars 0 forks source link

Incorrect class diagram format #10

Open djleong01 opened 7 months ago

djleong01 commented 7 months ago

image.png

perhaps missing "+" for itemManager class methods

soc-se-bot commented 7 months ago

Team's Response

By convention, an interface is understood to have public methods. An interface can never have private methods because it can never be implemented!

Adding "+" does not add value and is redundant.

photo1713688691.jpeg

The CS2113 website also did not include the "+"/"-" in front of the methods (seen above).

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]