djleong01 / pe

0 stars 0 forks source link

Class diagram is too complex #11

Open djleong01 opened 2 months ago

djleong01 commented 2 months ago

image.png

can consider omitting trivial class methods like "getSize()" and "getID" as they are likely to be repetitve and doesn't add value to a reader. Suggestion to focus on listing key methods in each class instead

can also consider breaking up the class diagrams and explain them instead in the following subsections

nus-pe-bot commented 2 months ago

Team's Response

The class diagram covers all the main classes, and we included all the methods for completion's sake. Furthermore, we don't think that listing the methods necessarily increase the "complexity" of the class diagram.

The CS2113 website did mention that utility classes and private functions can be omitted, but not necessarily methods, let alone public methods. Hence, we decided to include them so it is clearer to the reader.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]