djleong01 / pe

0 stars 0 forks source link

Receipt values reset after tampering with data file #4

Open djleong01 opened 2 months ago

djleong01 commented 2 months ago

image.png

after changing the order quantity to reflect a negative number (-3), the value of the receipts reset to 0, perhaps throwing a warning/exception for such cases might be better (nitpicking here)

nus-se-bot commented 2 months ago

Team's Response

dd4e02ea-b39f-44f7-8cde-1413b1601784.jpg

This is similar to #849 because the cause is due to tampering of the data files, which we warned the user not to do without the necessary knowledge of the formatting of the data within the data files.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

App allows for multiple items in the same menu to have the same ID

Screenshot 2024-04-19 at 5.07.56 PM.png

All the items in this menu (chicken, rice, chicken rice) have the same ID "1". This occurred after editing the data file.


[original: nus-cs2113-AY2324S2/pe-interim#1001] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

photo1713687900.jpeg

We mentioned within in the UG that if editing of data file is done there might be unexpected behavior in the program. Therefore, we recommended only editing the data file if the user can ensure that the format of the stored data is correct (only if the user can edit responsibly).

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]