Update H033 regex to ignore data-action

[Mouarius]

Pull Request Check List

Resolves: #issue-number-here

• [ ] Added tests for changed code.
• [ ] Updated documentation for changed code.

Description of the context

I came across a linting issue when using djlint along with Catalyst custom elements : I was using the data-action attribute on a form element with multiline content, as it is defined in the docs for multiple actions.

Code example :

<form action="#"
    method="get"
    data-action="
        submit:my-custom-element#handleFormSubmit
        click:my-custom-element#handleClick
        some-event:my-custom-element#handleSomething" >
    <!-- some content -->
</form>

Error

I got a linting H033 : Extra whitespace found in form action. error, not for the action but for the data-action. I want it to apply only to action attributes.

Reasons to fix it

I want to be able to have my actions string spanning over multiple lines without triggering an error with djlint, which maybe should not apply to a data-action attribute. This is maybe a minor change, and I'm not an expert of regex so maybe someone should review my regex and the legitimity of my proposition.

What do you guys think ?

[netlify[bot]]

✅ Deploy Preview for djlint canceled.

Name	Link
🔨 Latest commit	aa78ca7c73e15998484b73ae77b181a4093e40e1
🔍 Latest deploy log	https://app.netlify.com/sites/djlint/deploys/64e9cd9cef5667000767c37d

[silverwind]

Does not seem right. It should exactly match the action attribute and nothing else, so foo-actionshould also not trigger it.

[Mouarius]

Apparently it doesn't, it triggered this rule with my data-action attribute on my form. As an example, I've tested this regex and apparently it does match everything containing "action" in it : https://regex101.com/r/8YN0EZ/1 Maybe I could change it to be sure that it only matches "action" exactly.

[silverwind]

Your latest version seems good, but I think it can be simpler and just look for a whitespace before action, so it does not need a lookbehind:

https://regex101.com/r/3ZAco0/2

[Mouarius]

You're right ! I'm changing it right now ! Thank you !

Your latest version seems good, but I think it can be simpler and just look for a whitespace before action, so it does not need a lookbehind:

https://regex101.com/r/3ZAco0/2

You're right ! I'm changing it right now ! Thank you !

[silverwind]

Updated one more time, removed the unnecessary character class:

https://regex101.com/r/3ZAco0/3

[Mouarius]

I did it already ;)

[codecov[bot]]

Codecov Report

Patch and project coverage have no change.

Comparison is base (c339061) 95.35% compared to head (7c96cc6) 95.35%. Report is 7 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #743 +/- ## ======================================= Coverage 95.35% 95.35% ======================================= Files 16 16 Lines 1033 1033 Branches 278 278 ======================================= Hits 985 985 Misses 34 34 Partials 14 14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[christopherpickering]

Thanks for this, sorry I missed it! I will update the pr with a test and release.

[christopherpickering]

:tada: This PR is included in version 1.33.0 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: