djlint / djLint

✨ HTML Template Linter and Formatter. Django - Jinja - Nunjucks - Handlebars - GoLang
https://djLint.com
GNU General Public License v3.0
686 stars 84 forks source link

Fix missed H025 for double closing HTML tags #788

Closed MrkGrgsn closed 10 months ago

MrkGrgsn commented 11 months ago

I couldn't see any reason to keep orphaned closing tags in open_tags so store them separately to avoid accidental matches against subsequent closing tags.

Pull Request Check List

Resolves: #786

netlify[bot] commented 11 months ago

Deploy Preview for djlint canceled.

Name Link
Latest commit cf52faf1887e54d55ae02dff6d937c9205f5e533
Latest deploy log https://app.netlify.com/sites/djlint/deploys/6551876c2a5b34000861f06a
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (16b2319) 95.47% compared to head (cf52faf) 95.48%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #788 +/- ## ======================================= Coverage 95.47% 95.48% ======================================= Files 16 16 Lines 1061 1062 +1 Branches 283 283 ======================================= + Hits 1013 1014 +1 Misses 33 33 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

christopherpickering commented 10 months ago

@MrkGrgsn thanks for this!

christopherpickering commented 10 months ago

:tada: This PR is included in version 1.34.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: