Does this not work anymore or am I being stupid?

[chiubaca]

I'm running the example code but both children nodes are returning as type:paragraph ?

this is my package,.json if it helps:

{
  "name": "remark-shortcodes-quick-test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "remark-parse": "^9.0.0",
    "remark-shortcodes": "^0.3.1",
    "unified": "^9.2.0"
  }
}

[cammanderson]

I downgraded remark to match the version mentioned in this projects dev dependencies (e.g. ^8.0.0) and it started working

[chiubaca]

Thanks, looks like there was a breaking change to Remark last year which broke a bunch of plugins. This one included.

https://github.com/remarkjs/remark/pull/536

[djm]

Ah, that is a pain.

I don’t actually use this project and have not for about four years, so I can’t give time to do the upgrade myself but I will:

• pin the dependency version so people don’t hit this.
• write up and advertise for someone to tackle it.

On Mon, 18 Jan 2021 at 08:55, Alex Chiu notifications@github.com wrote:

Thanks, looks like there was a breaking change to Remark last year which broke a bunch of plugins. This one included.

remarkjs/remark#536 https://github.com/remarkjs/remark/pull/536

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/djm/remark-shortcodes/issues/21#issuecomment-762094090, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVVKCMLKI7OT3CMMSXMPTS2PZRTANCNFSM4VRFE77Q .

-- Darian Moody w: djm.org.uk

[djm]

Ticket to do the work to get this package on remark v13+: https://github.com/djm/remark-shortcodes/issues/19

Closing this ticket for now, so conversation can happen on the existing ticket. Cheers!