search

djm / remark-shortcodes

A custom Markdown syntax parser for remark that adds support for shortcodes.
MIT License
45 stars 7 forks source link

fix: make both compiler and parser optional #4

Closed ChristianMurphy closed 6 years ago

ChristianMurphy commented 6 years ago

This allows shortcode to be used in a parse only context or in a compile only context without throwing an error.

resolves #3

codecov-io commented 6 years ago

Codecov Report

Merging #4 into master will increase coverage by 2.08%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4      +/-   ##
=======================================
+ Coverage   95.91%   98%   +2.08%     
=======================================
  Files           1     1              
  Lines          49    50       +1     
=======================================
+ Hits           47    49       +2     
+ Misses          2     1       -1
Impacted Files Coverage Δ
index.js 98% <100%> (+2.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e67105c...590fcb6. Read the comment docs.

djm commented 6 years ago

Thanks for this!

jonheslop commented 6 years ago

Hi @djm, I am missing something or does this fix need be released?

Right now v0.2.0 is still broken with the same issue.

djm commented 6 years ago

Hi Jon (@jonheslop),

You're not missing anything, @ChristianMurphy kindly fixed it but I just have not had a lot of time on my hands to maintain this recently - thanks for your patience!

I've just chucked out v0.2.1 on npm and that should hopefully solve your issues.

jonheslop commented 6 years ago

Nice!

Ah brilliant thanks so much @djm 😄