[Android Bootcamp] Review my ImageSearch App #2

[djmalice]

My image Search app is ready to be reviewed.

I have couple of questions. 1) Spinner: a) I use default as one of the values for spinner for cases when i don't want to add any filters to the query. b) to repopulate the spinner with previously saved values, i store spinner id in the shared preferences.

Is there a better way to do a) and b)???

2) For checking network related issues, I used the networking code mentioned in the cliffnotes. For the implementation part, I only check if isNetworkAvailable() before doing a client.get(). I feel that this does not cover all the cases. is my implementation correct??

/cc @nesquena @timothy1ee

Chintan

[vibhorB]

Nice work Chintan. A few notes after checking out the code:

• You should reuse a single base method in search activity to fetch results for both initial load and the pagination, instead of duplicating the code at both places
• Properly used spinners (with populated values) to allow users to select filters
• Good work saving settings to SharedPrefs
• Nice to see you added the search box to the ActionBar
• Consider better organizing your source files
• Good job on error handling for Network check.

For your questions : 1.a I guess you can add a blank entry and that will be passed as a blank param to api, so you dont need an extra if-else where you check for a "Default" value 1.b This should be fine, since you need to save some sort of state. But I will check more and let you know if I find something.

1. Yes for such simple app, that is all that was required for handling network related issues

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.