djmango / BlackMarket2

A mod for Factorio economics
https://mods.factorio.com/mod/BlackMarket2
GNU General Public License v3.0
17 stars 7 forks source link

wanna fix a conflict #44

Closed NingWen-In-Hub closed 7 months ago

NingWen-In-Hub commented 7 months ago

Hello, I've identified a conflict between the BlackMarket2 and Py AlienLife mods, and I attempted to resolve it. The issue arose because a UI element in Py AlienLife didn't have the key "name," but BlackMarket2 was attempting to read "name." This caused the game to crash when I tried to open this UI. The traceback points to control.lua in BlackMarket2 at lines 2200 and 2156. To address this, I added a try-catch block around the reading of "name," and fortunately, I was able to compile it successfully.

I apologize once again for not being able to locate the specific changes made by Py AlienLife, which led to modifications in your mod.

I greatly appreciate the mod you've created; it has provided me with a lot of enjoyment in the game.

PS: My English isn't great either, so I'm using machine translation. I apologize for any errors. PS2: I'm also not familiar with Lua, so my coding skills are likely not very proficient.

djmango commented 7 months ago

LGTM. Thanks for the detailed write up and fix!