search

djmango / obsidian-transcription

Obsidian plugin to create high-quality transcriptions from markdown linked audio files
https://swiftink.io
MIT License
156 stars 17 forks source link

Single line responses #41

Closed amunrarara closed 8 months ago

amunrarara commented 8 months ago

Experimental, untested, but will possibly remedy the issue described in Issue #40

amunrarara commented 8 months ago

@djmango Please review

djmango commented 8 months ago

I've run a workflow to package the plugin with this code. However, this behavior change should be a setting, not a change in default. Please update accordingly and I'm happy to merge!

djmango commented 8 months ago

You're welcome to make the change with your own copy of the plugin, but the default behavior (what people have come to expect from the plugin) should not be changed. Happy to merge this into the distributed plugin if you made it a setting though.

amunrarara commented 8 months ago

@djmango Excellent, that makes sense. I've made the changes; it is now a setting, defaulting to multi-line return. Let me know if this PR is good-to-go!

FYI I haven't tested, because I don't have the local workflow set up yet for testing custom Obsidian plugins. Will set up the workflow for myself in the future.

amunrarara commented 8 months ago

@djmango Fixing error, one moment

djmango commented 8 months ago

That's the purpose of the workflow. It auto packages the application for you to test. It seems to have failed

https://github.com/djmango/obsidian-transcription/actions/runs/7722208435/job/21050070060?pr=41

The commands to test it yourself are also in the YAML

amunrarara commented 8 months ago

@djmango K, I've pushed the fix, let's see if the workflow is happy with it

djmango commented 8 months ago

LGTM

amunrarara commented 8 months ago

Woot woot! +1 and thank you!

amunrarara commented 8 months ago

@djmango How long until the changes are live in the Obsidian Community Plugin update menu?

djmango commented 8 months ago

Should be up