search

djmaze / librespot-snapserver

Snapcast server with Spotify support as a Docker container
https://hub.docker.com/r/mazzolino/librespot-snapserver/
GNU General Public License v3.0
58 stars 25 forks source link

Web GUI #6

Open charlesomer opened 4 years ago

charlesomer commented 4 years ago

Does this come with the web GUI (Snapweb)? I can't seem to be able to access it at :1780? The resource '/' was not found.

charlesomer commented 4 years ago

Also, the Spotify support link in the readme directs to the wrong GitHub page now :)

djmaze commented 4 years ago

Snapweb, interesting, didn't even know that existed. Could be a useful addition.

Personally, I don't need it, but I am open for PRs!

The link is fixed, thanks!

charlesomer commented 4 years ago

Yeah I think it's supposed to be shipped with Snapcast but I'm guessing the docker install does something differently which means it doesn't automatically get bundled.

charlesomer commented 4 years ago

Okay so it looks like Snapweb was only introduced in v0.21 and the version this uses is the default Debian one, which is (I believe) 0.15.0-1 https://packages.debian.org/buster/snapserver.

Maybe it's worth adapting this to use the latest one from the Github repo?

charlesomer commented 4 years ago

Hmm maybe not SNAPCAST_VERSION=0.20.0, looks like it just needs to be bumped up a version? :)

simon-zumbrunnen commented 3 years ago

As far as I know Snapweb was introduced in 0.21.0:

https://github.com/badaix/snapcast/releases/tag/v0.21.0

Is there a reason you are still on 0.19.x?

charlesomer commented 3 years ago

Sorry I'm not sure where 0.19.x is coming from, in the makefile it appears the version is: SNAPCAST_VERSION=0.20.0 so just needs updating by the looks of it?

djmaze commented 3 years ago

Yes, I should've tagged 0.20 already. And yes, we can update 0.21.

The problem is that arm builds are currently broken, which is actually an upstream issue at docker. I hope they fix it soon (or maybe they already fixed it even.)

simon-zumbrunnen commented 3 years ago

Sorry I'm not sure where 0.19.x is coming from, in the makefile it appears the version is: SNAPCAST_VERSION=0.20.0 so just needs updating by the looks of it?

0.19 is the version packaged for debian bullseye.

Yes, I should've tagged 0.20 already. And yes, we can update 0.21.

The problem is that arm builds are currently broken, which is actually an upstream issue at docker. I hope they fix it soon (or maybe they already fixed it even.)

This problem seems to have been around since last summer. Since I don't care about the arm build wouldn't it be possible to release the arm builds with a different version? E.g. use debian bullseye package for arm build (and tag it 0.19) and use the .deb file for the other build?