djmelik / lndash

A simple web dashboard for lnd.
https://lightninglayer.com
GNU General Public License v3.0
118 stars 16 forks source link

Push image to Docker Hub #31

Open meeDamian opened 5 years ago

meeDamian commented 5 years ago

Since Dockerfile is already provided, why not also push it to Docker Hub to make using it easier?

Note that both Docker Hub and Travis are able to build and push it automatically on a push to master or git tag.

meeDamian commented 5 years ago

Happy to setup Docker Hub pipeline if I get (even temporarily) added as a collaborator here.

djmelik commented 5 years ago

Just sent you an invite, thanks for your help!

meeDamian commented 5 years ago

Thanks! I'll get to it soon :)

meeDamian commented 5 years ago

Okay…

  1. I'm sorry I accidentally pushed straight to master here - I confused remotes 🙈
  2. @djmelik as it's probably better to have Docker tag the same as Github path, there's one thing you need to do:

    1. Go to: https://travis-ci.org/djmelik/lndash/settings

    2. Fill-in your Docker credentials as on the picture below:

      MacOS 2019-03-23 at 01 17 44
    3. If your Docker username is different than djmelik, you also need to adjust these things

Once you complete that, Travis should test all pushes to master and push them forward to Docker Hub as :latest tag. Each git tag will also get Docker-tagged accordingly.

meeDamian commented 5 years ago

Alternatively, I can set it up if you create and add me as a collaborator to Docker Hub https://hub.docker.com/r/djmelik/lndash as well.