djnavarro / rbook

Source files for "Learning Statistics with R"
https://learningstatisticswithr.com
474 stars 157 forks source link

Current known broken links #8

Open Maschette opened 5 years ago

Maschette commented 5 years ago

Figures where the image doesn't appear in learningstatisticswithr.com/book: 3.2 3.3 3.4 3.5 3.6 4.1 4.2 4.3 4.4 4.5 4.6 4.7 4.8 4.9 4.10 6.5 6.6 6.13 6.18

in chapter 6 broken links: we discussed in Section ?? is shown in Figure ??. The R command that I used to draw it is this:

I’ll use the tabulate() function to do this (which will be discussed properly in Section ??, since it creates a simple numeric vector:

To do this, we need to alter set the las parameter, which I discussed briefly in Section ??. What I’ll do is tell R

I have checked up to chapter 7 and will add others as I see them.

ekothe commented 5 years ago

Many of these are figures that should be generated using live code but where I couldn't locate the source. I went through made images from the PDF (eek). Personally I think making them live coded would be better (since they won't have image compression issues in different formats and also allow people to see code examples if they want to dig into the back end).

@djnavarro might source for these somewhere but I think some of them should be pretty easy just to build from scratch and there is potentially an argument to redoing some (or all) of them in ggplot if we want to go down that route anyway.

Here are the missing links in a task list format so we can keep track more easily.

Rather than add a new comment I have added the rest to your list, this is all the ones I easily found, there are some reference links broken (i saw at least one) but I haven't listed them yet. -Dale

Figures: Chapter 3

Chapter 4

Chapter 6

Chapter 9 After figure 9.15 none of the plots have figure captions

Chapter 10

Chapter 13

Tables

Chapter 10

Chapter 13

Chapter 14

Chapter 15

Chapter 16

Chapter 17

Text: Chapter 4

Chapter 5

Chapter 6

Chapter 7

Chapter 9

Chapter 10

Chapter 11

Chapter 16

Maschette commented 5 years ago

References Chapter 3.12

Chapter 5

Chapter 6

Chapter 10

Chapter 12

Chapter 14

Chapter 17

Maschette commented 4 years ago

I have been going through the bookdown and there are a lot of broken image links where the code is looking for a png but they don't exist. often eps do though. There are however a few images missing based off the file names. wilcox1.eps, wilcox2.eps

For the minute so I could export an epub I have commented them out.

The other issue is there are a few instances where there are multi-panel figures where each panel is a separate file. I haven't worked out which are which and made sure it is loading all the images rather than just the one in the existing file paths.

Shortly I will send a pull request with the updated paths and the epub version. I will leave it to someone else to add the download option to the bookdown as bookdown YAML scares me.... There are tips here: https://bookdown.org/yihui/bookdown/html.html#gitbook-style

I'll just add the style formatting on the generic ebook is pretty average but it seems to work on my phone at least.