search

djodjoni / mytracks

Automatically exported from code.google.com/p/mytracks
0 stars 1 forks source link

ANT+ cadence sensor support #757

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Mercurial clone with changes to be reviewed:
ezerotven-mytracks1

Revisions to be pulled from that clone (or "all"):
all

Purpose of code changes on the clone:
Extending AntDirectSensorManager to handle other sensor types not just HRM.
Currently HRM (tested), Cadence (tested), and combined Cadence&Speed (untested) 
are supported. But POWER support could be also added in the future. 

When reviewing my code changes, please focus on:
a, Whether the class hierarchy is correct.
b, I see strange debug message sequences in the logs, when SensorStateActivity 
is running and track recording is started. Still looking at it.

Did you run the unit tests?
In Eclipse, select the 'MyTracksTest' project, right click, 'Run As' ->
'Android JUnit Test'.

I can not build it. This is the first error message I see:

Internal compiler error: java.lang.NoClassDefFoundError: android/os/Parcelable 
at java.lang.ClassLoader.defineClass1(Native 
Method) ChartValueSeriesTest.java   /MyTracksTest/src/com/google/android/apps/mytr
acks    line 0  Java Problem

Did you allow others to review code on your clone?
From your clone, 'Administer' -> 'Source' -> 'Code reviews'
-> check 'Enable code reviews'
-> check 'Allow non-members to review code'

done.

Original issue reported on code.google.com by ezerot...@gmail.com on 17 Jan 2012 at 3:37

GoogleCodeExporter commented 9 years ago 
Oddly after almost a year of no activity on this front I think we have two 
implementations of this functionality.  I am going to give the advice I gave on:
http://code.google.com/p/mytracks/issues/detail?id=756

It is very hard for a reviewer to see changes across many commits.  Please 
either manually or with a tool collapse the commits into one.  We will have to 
compare these two versions and try to take the best from both.

Original comment by sandordo...@google.com on 17 Jan 2012 at 5:40

GoogleCodeExporter commented 9 years ago 
Okay, I guess this means that I have to create a new clone, and kill the 
original. I will do it tomorrow.

Original comment by ezerot...@gmail.com on 17 Jan 2012 at 7:52

GoogleCodeExporter commented 9 years ago 
I've created a new clone (ezerotven-mytracks2) for the collapsed changes.

Original comment by ezerot...@gmail.com on 18 Jan 2012 at 12:40

GoogleCodeExporter commented 9 years ago 
When running the tests on an emulator (as my xperia x8 seems to be too old for 
this), I see this exception, because the parameter directory=null:

Maybe you have a quick fix for this?

DalvikVM[localhost:8602]    
    Thread [<1> main] (Running) 
    Thread [<11> Instr: android.test.InstrumentationTestRunner] (Running)   
    Thread [<10> Binder Thread #2] (Running)    
    Thread [<9> Binder Thread #1] (Running) 
    Daemon Thread [<8> FinalizerWatchdogDaemon] (Running)   
    Daemon Thread [<7> FinalizerDaemon] (Running)   
    Daemon Thread [<6> ReferenceQueueDaemon] (Running)  
    Thread [<14> android.hardware.SensorManager$SensorThread] (Running) 
    Thread [<16> pool-2-thread-1] (Running) 
    Thread [<19> Binder Thread #3] (Running)    
    Thread [<12> Thread-159] (Suspended (exception NullPointerException))   
        FileUtils.buildUniqueFileName(File, String, String) line: 107   
        TrackWriterTest$OpenFileTrackWriter(TrackWriterImpl).openFile() line: 198   
        TrackWriterTest$OpenFileTrackWriter(TrackWriterImpl).doWriteTrack() line: 119   
        TrackWriterImpl.access$0(TrackWriterImpl) line: 114 
        TrackWriterImpl$1.run() line: 98

Original comment by ezerot...@gmail.com on 24 Jan 2012 at 2:57

GoogleCodeExporter commented 9 years ago 
Jimmy have you seen this error?  I actually have not run the tests in a while.

Original comment by sandordo...@google.com on 24 Jan 2012 at 5:42

GoogleCodeExporter commented 9 years ago 
I am seeing these errors. I think they are due to previous changes. Please 
ignore the 3 errors in TrackWriterTest. I will investigate and fix soon.

Original comment by jshih@google.com on 24 Jan 2012 at 6:34

GoogleCodeExporter commented 9 years ago 
Finally I've figured out how to run only my tests from eclipse, so here is a 
new changeset for my stuff.

Revision: 201f8f6de473

Original comment by ezerot...@gmail.com on 26 Jan 2012 at 11:52

GoogleCodeExporter commented 9 years ago 
Jimmy for real this time.  Please pull in these changes.

Original comment by sandordo...@google.com on 31 Jan 2012 at 6:28

GoogleCodeExporter commented 9 years ago 
Done. Pushed the main. Thanks for the great work.

Original comment by jshih@google.com on 2 Feb 2012 at 1:55