search

djong1 / gp3s

gps-speedsurfing and more
6 stars 1 forks source link

"Ghost speeds" in rankings and personal bests #11

Closed Logiqx closed 2 years ago

Logiqx commented 2 years ago

There are several closely related issues within this single issue.

1) The UK foil rankings contain some "ghost speeds" for Ben Clothier.

2) Ben's personal bests also contain the "ghost speeds" relating to a session (or sessions) which have since been deleted.

3) It is also worth noting that this issue of "ghost speeds" also exists on gps-speedsurfing:

djong1 commented 2 years ago

Thanks for reporting, the bug is identified and fixed. This fix does not apply to the current rankings, we still need to work on a script to rebuild the rankings for users that are affected by this bug. In the time between now and the rebuild you can report riders that are affected and we can update the rankings on a per rider bases.

Logiqx commented 2 years ago

Here are two IDs that need rebuilding on gps-speedsurfing:

5246 - Matthew Spooner 22323 - Tyler Baker

Here is one user ID that needs rebuilding on gps-foilsurfing:

24525 - Ben Clothier

jhdebruin commented 2 years ago

@Logiqx I've done some rebuilds on on the specified UID's, could you confirm this is ok now ?

Logiqx commented 2 years ago

gps-speedsurfing (Matthew and Tyler):

gps-foilsurfing (Ben):

Logiqx commented 2 years ago

I've added issue #21 which requests a Spot_Sessions method on the GP3S API.

This will allow the Python script that checks event rankings to also check spot rankings, highlighting ghost results, etc.

Logiqx commented 2 years ago

@jhdebruin - Aside from the Dunkerbeck event, only 3 events on GP3S still contain "ghost" rankings.

https://logiqx.github.io/gp3s-query/events/

I suspect a rebuild of these events / users may well fix the problem.

jhdebruin commented 2 years ago

Check, will do some actions tomorrow or tonight, and let's we can fix them all

Logiqx commented 2 years ago

Worth noting that "ghost" rankings generally seem to have one of two confirmed possible causes:

A third possible cause is the session being edited and a different event being selected. I haven't stumbled across this scenario but it seems possible.

jhdebruin commented 2 years ago

Most likely the two options above, its not that easy to change an event afterwards.... don't think there is a menu option for that either

Logiqx commented 2 years ago

@jhdebruin

Most likely the two options above, its not that easy to change an event afterwards.... don't think there is a menu option for that either

Bad phrasing on my part. What I meant is editing the session and selecting a different event.

jhdebruin commented 2 years ago

Fixed ->

spot rankings (Portland Harbour) are still showing ghost speeds (e.g. 500m)

https://www.gps-speedsurfing.com/default.aspx?mnu=rankings&Year2=-&countryID2=268&SpotID2=681&Gender2=0&Tab=2&WeightClass2=0&AgeClass2=0&SpeedType2=3

jhdebruin commented 2 years ago

Rebuild seems not to work for this one ->

https://www.gps-foilsurfing.com/default.aspx?mnu=user&val=327504&uid=24525 , will make an new issue for this

Logiqx commented 2 years ago

Rebuild seems not to work for this one ->

https://www.gps-foilsurfing.com/default.aspx?mnu=user&val=327504&uid=24525 , will make an new issue for this

Makes sense. I can see this is issue #27.

I can also confirm the other issues have been fixed.