djong1 / gp3s

gps-speedsurfing and more
6 stars 1 forks source link

API - Several speed types missing from Event_Sessions #16

Closed Logiqx closed 1 year ago

Logiqx commented 1 year ago

Whilst using the API, I noticed that a number of the speed types are absent in Event_Sessions and User_Sessions.

speed_alpha_racing and speed_halfhour are potentially the most interesting of these speed types.

If the missing speed types can be added to the Event_Sessions output it would be quite useful.

Logiqx commented 1 year ago

Worth noting that these additions will be particularly useful to my Python script for checking event rankings.

https://github.com/Logiqx/gp3s-query

Currently, it can't check these 5 speed types without them being in the Event_Sessions.

djong1 commented 1 year ago

I would like to take the opportunity to improve the API in a later time-frame and add this request to the V2 API

Logiqx commented 1 year ago

@djong1 That's fair enough.

I've just noticed that these fields are also absent from User_Sessions so I'll update the first comment.

Hopefully there aren't too many speed_alpha_racing and speed_halfhour errors in the event rankings.

djong1 commented 1 year ago

@Logiqx we have released a beta version of the API: gps-speedsurfing-api-v2

Changed Ranking and sessions, don't use spotranking yet.

    added speed fields in rankings:

    - speed_24hour
    - speed_alpha_racing
    - speed_halfhour

    These speed types will not be added:
    - speed_foil
    - speed_formula

Added speed types in sessions, is inline with rankings Shows now complete set of sessions to be in-line with the latest event module update

The api parameter path changed a bit,

The API is not yet multi-website but will add soon

please comment @Logiqx

Logiqx commented 1 year ago

@djong1

I'm having trouble with event sessions. Maybe the service docs aren't quite right?

image

djong1 commented 1 year ago

@Logiqx is fixed now, but I need to add pagination to overcome timeout issues for huge event lists

Logiqx commented 1 year ago

@djong1 A few things to address:

I've re-run the reports which now list a lot of issues.

https://logiqx.github.io/gp3s-query/events/

I've only checked a few things but they seem legit errors.

e.g. https://logiqx.github.io/gp3s-query/events/726.html - Robert Baas is missing from the rankings

djong1 commented 1 year ago

sessionurl = fixed performance is fixed

please confirm that this works, this update apply's only for the events hosted in 2022 and for gps-speedsurfing. When this approach works we will apply it to the older events also and other websites. Can you also run a new matching run?

Logiqx commented 1 year ago

@djong1

Thanks, looking better now - https://logiqx.github.io/gp3s-query/events/

3 events with lots of "ghosts" are showing zero sessions, despite having rankings:

I'll let you work your way through the other errors being reported.

Can you use a standard format for session_date in event sessions please?

djong1 commented 1 year ago

closed, api updated