search

djong1 / gp3s

gps-speedsurfing and more
6 stars 1 forks source link

Sail material update - edit function malfunctions (rounding) #233

Closed LucSalomons closed 2 months ago

LucSalomons commented 10 months ago

Hi after adding and updating sails (2024 Duotone Warp_Fin) the sail size gets rounded to 0

Example: sail size 8,4 shows as 8,0 as does 7,8

8,0 should be 8,4 8,0 should be 7,8 7,0 should be 6,8 6,0 should be 5,8 5,0 = 5,0

Schermafbeelding 2023-12-07 om 16 31 48
LucSalomons commented 9 months ago

If it is easier for you to just delete these sails, so that I can create new ones; please let me know. But I would like to avoid double entries. The issue that it goed wrong with the rounding after editing a sail will however still remain.

jhdebruin commented 9 months ago

If it is easier for you to just delete these sails, so that I can create new ones; please let me know. But I would like to avoid double entries. The issue that it goed wrong with the rounding after editing a sail will however still remain.

For the short term, please delete them, in the next weeks we have some time to take a closer look and fix it for improvement

LucSalomons commented 9 months ago

Thx for the reply. As soon as these are deleted by @djong1 I will create the correct ones. (I Just need to make sure that I don't need to edit them again afterwards, because then the bug arises)

LucSalomons commented 9 months ago

I added the correct ones and flagged (the ones where above issues is applicable) the rest for deletion

djong1 commented 9 months ago

implemented a fix, can you test and let us know?

LucSalomons commented 9 months ago

Hi Dylan,

No, not fixed.

  1. I added the 2024 Duotone S_Pace 8,8
  2. Then I edited this same sail to 7,8
  3. Now it shows in the list as: 8,0

KR, Luc

Op 3 jan. 2024, om 16:20 heeft Dylan de Jong @.***> het volgende geschreven:

implemented a fix, can you test and let us know?

— Reply to this email directly, view it on GitHub https://github.com/djong1/gp3s/issues/233#issuecomment-1875539012, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIQ7ON2R776DL6TZU6EKR3YMVZLFAVCNFSM6AAAAABALID7Y2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVGUZTSMBRGI. You are receiving this because you authored the thread.

djong1 commented 9 months ago

oh sorry, was not yet staged to production. Can you please check again...

LucSalomons commented 9 months ago

Nope: changed/edited the S_Pace 7,8 to 8,8 and now it shows in the list as 9,0

Op 3 jan. 2024, om 16:42 heeft Dylan de Jong @.***> het volgende geschreven:

oh sorry, was not yet staged to production. Can you please check again...

— Reply to this email directly, view it on GitHub https://github.com/djong1/gp3s/issues/233#issuecomment-1875571917, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIQ7OLEG7LSJRVP2CE337DYMV37ZAVCNFSM6AAAAABALID7Y2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVGU3TCOJRG4. You are receiving this because you authored the thread.

djong1 commented 9 months ago

durf het bijna niet te vragen, maar kan je nog een testje doen?

LucSalomons commented 9 months ago

Het werkt!

Ik heb de ontstane “vervuiling” dubbel gemarkeerd: 1. maat = 0,0 2. en ik heb ze met de checkbox gemarkeerd voor deletion. Zie hieronder. Kunnen deze er zsm uit?

Dank en groeten, Luc

Op 4 jan. 2024, om 14:31 heeft Dylan de Jong @.***> het volgende geschreven:

durf het bijna niet te vragen, maar kan je nog een testje doen?

— Reply to this email directly, view it on GitHub https://github.com/djong1/gp3s/issues/233#issuecomment-1877100318, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIQ7OLCSLV5VZD2DDW42HDYM2VMLAVCNFSM6AAAAABALID7Y2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGEYDAMZRHA. You are receiving this because you authored the thread.

djong1 commented 9 months ago

nice, we kunnen ook materiaal lijsten in bulk importeren, maar de leveranciers zijn vaak te lui om die aan te leveren. Maar als je die hebt voor DUOTone dan kan dat ook gebruikt worden.