Closed unclechunk closed 2 years ago
So your ask is to have more parameters in the list, the needed parameters are:
please advise if this list is correct
Yes, that looks correct
On 27 Sep 2022, at 07:51, Dylan de Jong @.***> wrote:
So your ask is to have more parameters in the list, the needed parameters are:
Brand Name production year (numeric) Mast size (numeric) Front Foil (description or numeric?) Rear Foil (description or numeric?) Fuselage (description ?) please advise if this list is correct
— Reply to this email directly, view it on GitHub https://github.com/djong1/gp3s/issues/54#issuecomment-1259060788, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUZM3BT5AW2AW47ZIPSEXTWAKKN5ANCNFSM6AAAAAAQT5CQWM. You are receiving this because you authored the thread.
@unclechunk should 5, 6 and 7 be numeric or tekst?
Probably text (5, 6 and 7) as some are measured in volume and others in size and others in text (e.g. xxl or TC70, etc.).
On 27 Sep 2022, at 12:14, Dylan de Jong @.***> wrote:
@unclechunk https://github.com/unclechunk should 5, 6 and 7 be numeric or tekst?
— Reply to this email directly, view it on GitHub https://github.com/djong1/gp3s/issues/54#issuecomment-1259349546, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUZM3GKSSMGXMF5TX66XADWALJKLANCNFSM6AAAAAAQT5CQWM. You are receiving this because you were mentioned.
Fix created and deployed to production, release 35698. please confirm @unclechunk
It shows as “Add a new fin", can it say "Add a new Foil".
Example data (this is my foil):
Foil Brand: Simmer Front Wing Size: 1600 Rear Wing Size: 310 Fuselage length: 650mm Mast length: 750mm (placeholder says “fin length”) Category: Aluminium / Carbon Prod. Year: 2022
On 27 Sep 2022, at 17:33, Dylan de Jong @.***> wrote:
Fix created and deployed to production, release 35698. please confirm @unclechunk https://github.com/unclechunk — Reply to this email directly, view it on GitHub https://github.com/djong1/gp3s/issues/54#issuecomment-1259763954, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUZM3HXXC4WK55U47UZXY3WAMOURANCNFSM6AAAAAAQT5CQWM. You are receiving this because you were mentioned.
New build deployed with additional fix please test
skipped category
This isn’t complete as far as I can tell? The brand isn’t saving from the add new fin form, its still taking the brand from the form before. Only the second form has Simmer in it, the first list of brands is still different to the second and “Simmer” isn’t there or Cabrinha and maybe a few other Foil brands.
On 28 Sep 2022, at 07:08, Dylan de Jong @.***> wrote:
Closed #54 https://github.com/djong1/gp3s/issues/54 as completed.
— Reply to this email directly, view it on GitHub https://github.com/djong1/gp3s/issues/54#event-7474519974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUZM3GN3G3GI3JLCETDV33WAPOHBANCNFSM6AAAAAAQT5CQWM. You are receiving this because you were mentioned.
Also the table at the top doesn't list the front wing and rear wing and fuselage sizes. We don't really need category as that can be in the "type" box or the logo column. PS. I've added a couple of entries trying to get it into the system, can you remove the "Blackbird 75 Foil" one. Obviously myself and someone else have had to bypass the brand field and put it into the "Type" field description because the brand isn't available.
Nearly there. It wouldn’t let me save the Brand “Simmer”
If I select any brand (as Simmer isn’t there) then click Go.
This then gives me the “Add missing equipment our database” When I click this it then gives me a slightly different brand list that does include “Simmer”, when I select/add all the details for the new item, it doesn’t save everything in that form, it saves the random brand I selected to get the form to display. Also the table with the list of fins, doesn’t show all the fields in the form.
On 27 Sep 2022, at 21:34, Dylan de Jong @.***> wrote:
New build deployed with additional fix please test
— Reply to this email directly, view it on GitHub https://github.com/djong1/gp3s/issues/54#issuecomment-1260017204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUZM3HTLA65BMTYGTV62LDWANK4JANCNFSM6AAAAAAQT5CQWM. You are receiving this because you were mentioned.
I can't add my foils as you don't give us an option to Add, even though it says "only add if it's not in the list". This may need a few more options than the windsurfing page as you'll need mast, front foil, rear foil, fuselage.