search

djoos-cookbooks / composer

Repository for composer cookbook
http://community.opscode.com/cookbooks/composer
MIT License
27 stars 38 forks source link

Remove php cookbook dependency #56

Closed bdclark closed 2 years ago

bdclark commented 9 years ago

This cookbook doesn't specifically depend on the php cookbook, only on PHP itself. This PR removes the dependency while preserving integration tests, etc.

I'm also suggesting removal of the ['composer']['php_recipe'] node attribute and the related include_recipe to install PHP. Anything related to PHP installation seems out-of-scope for this cookbook. It's just as simple for someone to include recipe[php::default] earlier in their run list (and seems more "Chef-ish"). Plus it solves the issue of those who don't have a PHP recipe to point to (e.g. if they're using a custom AWS AMI with PHP pre-installed).

djoos commented 9 years ago

Hi @bdclark,

thanks for the PR!

Definitely makes sense to me, however: what about adding in a clear error to the user who (there's bound to be one!) includes the composer cookbook into their run list without having PHP installed at all?

Thanks in advance for your feedback!

Kind regards, David

djoos commented 9 years ago

Linking this up to issue #57...

djoos commented 2 years ago

I'm going to close this PR, given #82 supersedes it.

Hope this helps!