Improvements to composer_project resource

daften commented 7 years ago

Hi,

This bundles some improvements to the composer_project resource:

Vendor shouldn't be required, except for require/remove, it definitely shouldn't be the name attribute, that is the folder
Removed path attribute, it is never used anyway
Improved idempotency. Until now the guards were used to check for composer presence, that shouldn't be done. This way installs will fail silently when composer isn't present. Guards are only there for idempotency, I have added that so require/remove are only run when needed. If you don't specify a version number and use * in it, it will update. Other types of require where you'd expect an update, won't work. It can easily be adapted to include ~ and ^ as items to don't apply the guard.
Split vendor into package and version. Vendor was the wrong name anyway, vendor is just the first part of the package name. Splitting version allows for decent idempotency checks.

Please let me know what you think.

djoos commented 7 years ago

Hi Daften,

am I ok to understand that #62 includes #61 changes as well?

If so: shall we close this specific PR #61?

Thanks in advance!

daften commented 7 years ago

Jup, #62 includes this, but it's easy to rebase that other one, thought it might be easier to comment on the specific changes here.

djoos commented 7 years ago

Sorry, I ended up already starting a review on #62 :-/

daften commented 7 years ago

No worries, I'll close this one :D

djoos-cookbooks / composer