djoos-cookbooks / composer

Repository for composer cookbook

http://community.opscode.com/cookbooks/composer

MIT License

27 stars 38 forks source link

Chef 17 compatibility & cleanup #81

Closed detjensrobert closed 2 years ago

detjensrobert commented 3 years ago

Description

Chef 17 requires resources to enable unified_mode in preparation for Chef 18 when it will be the default mode.

This PR also applies the latest Cookstyle corrections and cleans up the cookbook and testing infrastructure to use modern tools.

Changes

This PR should have no outward-facing changes.

Remove Foodcritic (superseded by Cookstyle)
Enable unified_mode for custom resources
Apply latest Cookstyle fixes
convert integration tests to InSpec
Update Travis CI to latest Chef Workstation

detjensrobert commented 3 years ago

@djoos friendly ping to review this when you get a chance :)

djoos commented 2 years ago

Thank you for your contribution @detjensrobert - apologies for the delay in getting this merged though!

ramereth commented 2 years ago

Thank you for your contribution @detjensrobert - apologies for the delay in getting this merged though!

@djoos Can you please do a new release to the supermarket which includes this fix? Thanks!

ramereth commented 2 years ago

@djoos ping?

djoos commented 2 years ago

@ramereth: I've still got a note to address the CHANGELOG.md and version bump (3.0.0 most likely due to the adjustment cutting out EOL Chef versions) and can then push it up.

ramereth commented 2 years ago

@djoos any updates on getting this released? Thanks!

djoos commented 2 years ago

I settled for 2.8.0 rather than a major bump and published the cookbook on the supermarket now. Sorry for the delay!

Thanks again for your contribution @detjensrobert and thanks for chasing this up @ramereth as otherwise it would have probably taken even longer! :-)