djoos-cookbooks / newrelic

Development repository for the newrelic cookbook
https://supermarket.chef.io/cookbooks/newrelic
MIT License
143 stars 245 forks source link

node.default['newrelic']['ruby_agent']['install_dir'] is set to '' #227

Open gswallow opened 8 years ago

gswallow commented 8 years ago

The ['newrelic']['ruby_agent']['install_dir'] attribute is set to an empty string, and from what I can tell, it should not be. Additionally, the ruby_agent.rb recipe should supply an install_dir to the newrelic_agent_ruby LWRP, and it does not.

I can submit a pull request unless I'm wrong.

djoos commented 8 years ago

Hi @gswallow,

the attribute is set to an empty string, however the resource has the default set to '/opt/newrelic/ruby'.

You're right, the recipe is missing the install_dir if you want to set it that way. Would you mind submitting a PR to fix this? In the meantime you can make use of the LWRP and set the attribute to the value you require...

Thanks in advance!

Kind regards, David