Incorrectly named log_file_name parameter for java / ruby agents

djoos-cookbooks / newrelic

Development repository for the newrelic cookbook

https://supermarket.chef.io/cookbooks/newrelic

MIT License

143 stars 247 forks source link

Incorrectly named log_file_name parameter for java / ruby agents #264

Open petergphillips opened 8 years ago

petergphillips commented 8 years ago

templates/default/agent/newrelic.yml.erb sets a log_file parameter. Unfortunately the naming of the parameter isn't consistent amongst the different languages. For python this is correct, but for java and ruby it is called log_file_name instead.

I've manually changed a deployed yml file and confirmed for java that the agent does indeed rely on the name being called log_file_name. From what I can tell that yaml file is only used by the java and ruby agents so should be safe to rename?

djoos commented 7 years ago

Hi @petergphillips,

would you mind sending your fix in via a PR?

Thanks in advance!

Kind regards, David