djoos-cookbooks / newrelic

Development repository for the newrelic cookbook
https://supermarket.chef.io/cookbooks/newrelic
MIT License
143 stars 245 forks source link

Option group's value #<Chef::Node::Attribute:0x00000002e3efe8> does not match regular expression [/^([-a-zA-Z0-9_.\\ ]+)$/, /^\d+$/] #27

Closed JoeDeVries closed 11 years ago

JoeDeVries commented 11 years ago

While upgrading from 0.5.0 to 0.5.2, Chef threw the following error:

Recipe Compile Error in /opt/sailpoint/chef/cookbooks/newrelic/recipes/default.rb

Chef::Exceptions::ValidationFailed

Option group's value #Chef::Node::Attribute:0x00000002e3efe8 does not match regular expression [/^([-a-zA-Z0-9_.\ ]+)$/, /^\d+$/]

Cookbook Trace:

/opt/sailpoint/chef/cookbooks/newrelic/recipes/server-monitor.rb:19:in block in from_file' /opt/sailpoint/chef/cookbooks/newrelic/recipes/server-monitor.rb:16:infrom_file' /opt/sailpoint/chef/cookbooks/newrelic/recipes/default.rb:9:in `from_file'

Relevant File Content:

/opt/sailpoint/chef/cookbooks/newrelic/recipes/server-monitor.rb:

12: action :install 13: end 14: 15: #configure your New Relic license key 16: template "#{node['newrelic']['config_path']}/nrsysmond.cfg" do 17: source "nrsysmond.cfg.erb" 18: owner "root" 19>> group node['newrelic']['config_file_group'] 20: mode "640" 21: variables( 22: :license => node['newrelic']['server_monitoring']['license'], 23: :logfile => node['newrelic']['server_monitoring']['logfile'], 24: :loglevel => node['newrelic']['server_monitoring']['loglevel'], 25: :proxy => node['newrelic']['server_monitoring']['proxy'], 26: :ssl => node['newrelic']['server_monitoring']['ssl'], 27: :ssl_ca_path => node['newrelic']['server_monitoring']['ssl_ca_path'], 28: :ssl_ca_bundle => node['newrelic']['server_monitoring']['ssl_ca_bundle'],

djoos commented 11 years ago

Hi @JoeDeVries,

I've found the issue - see: http://tickets.opscode.com/browse/CHEF-520 The attributes/server-monitoring.rb contains value_for_platform-logic, which shouldn't be used. I'll implement a similar way of working to the one used in php-agent.rb to set the web server's service name: a simple attribute. Any deviations can then be set via an override rather than hard-wiring/putting the logic in the cookbook.

What do you think?

Kind regards, David

djoos commented 11 years ago

Hi @JoeDeVries,

would you be able to pull down the latest version from GitHub and give that a go? I've just put a fix in place - but would like to get your feedback prior to releasing a 0.5.3-version of the community cookbook.

Thanks in advance!

Kind regards, David

JoeDeVries commented 11 years ago

That resolved the problem. Thanks!

djoos commented 11 years ago

Hi Joe,

you're welcome - thanks for your feedback!

Kind regards, David