Fix infrastructure agent for Ubuntu and Amazon Linux

djoos-cookbooks / newrelic

Development repository for the newrelic cookbook

https://supermarket.chef.io/cookbooks/newrelic

MIT License

143 stars 247 forks source link

Fix infrastructure agent for Ubuntu and Amazon Linux #362

Closed JCapriotti closed 5 years ago

JCapriotti commented 5 years ago

Amazon Linux version detection was incorrect:
- 1.x version is in "YEAR.MONTH" format
- 2.x is 2.x
Ubuntu platform was incorrectly detected

Added tests for both.

Fixes #352 and probably #343

mdarii commented 5 years ago

Hi @djoos

Do you know when this changes will be merged?

Thank you

djoos commented 5 years ago

@mdarii: thanks for the nudge! @JCapriotti: thanks for your contribution!

Kind regards, David

djoos commented 5 years ago

ChefDK (2.3.1 @ Travis via chef-stable-precise) didn't have the referenced Amazon Fauxhai platforms. At least Fauxhai v6.2.0 was required, which seemed to have shipped in ChefDK 3.0.27.

Obviously Precise Pangolin (Ubuntu 12.04LTS) was way out of date, so bumped it to Trusty Tahr as Bionic Beaver (Ubuntu 18.04LTS) and Xenial Xerus (Ubuntu 16.04LTS) seemed a step to far (failed to fetch chefdk).

So, now a whole list of RuboCop failures; TBC!