search

djoos-cookbooks / newrelic

Development repository for the newrelic cookbook
https://supermarket.chef.io/cookbooks/newrelic
MIT License
143 stars 247 forks source link

Every node attribute used a default value to a property needs a `lazy { }` around it. #368

Closed lamont-granquist closed 3 years ago

lamont-granquist commented 5 years ago

related to #345, but every other one of the values needs lazy {} as well, e.g.:

https://github.com/djoos-cookbooks/newrelic/blob/master/resources/yml.rb#L28

(just to pick one).

see for example:

https://github.com/chef/chef/blob/60fe89dcf071ded1249adad59fd1df0c098d7f42/lib/chef/resource/apt_repository.rb#L46

fernandoaleman commented 4 years ago

Just ran into this problem as well. Adding lazy {} to the default attributes fixes the problem. @djoos Any chance of getting this fixed soon?

fernandoaleman commented 4 years ago

@djoos Hello again. Any chance this pull request can be merged in to fix this issue soon? Much appreciated.

barrowkwan commented 4 years ago

this broken our unit test. can this fix merge soon? thanks

fernandoaleman commented 3 years ago

@djoos I see you finally made some updates recently. Any chance of getting this fixed soon?

djoos commented 3 years ago

Apologies for the super late merge; this is now shipped in v2.43.0... Thank you for your patience!

fernandoaleman commented 3 years ago

Apologies for the super late merge; this is now shipped in v2.43.0... Thank you for your patience!

Thanks so much @djoos this is very helpful. 👍